fix: don't use deprecated API in config_parser#163
Open
artemsheinacn wants to merge 1 commit intoeclipse-score:mainfrom
Open
fix: don't use deprecated API in config_parser#163artemsheinacn wants to merge 1 commit intoeclipse-score:mainfrom
artemsheinacn wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
artemsheinacn
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
LittleHuba
added
the
import-started-do-not-modify
LittleHuba
reviewed
Feb 23, 2026
Contributor
LittleHuba
left a comment
LittleHuba
left a comment
There was a problem hiding this comment.
Merge commits are prohibited. Please remove the merge commit.
Change-Id: I23abf01e3f32746e329a2e997dcf000ff6ff9909
artemsheinacn
force-pushed
the
cr-204680
branch
from
f4a1e55 to
f5b9ca1
Compare
Contributor
|
Thanks, restarting the import now. Please do not push anymore. |
LittleHuba
requested changes
Feb 23, 2026
Contributor
LittleHuba
left a comment
LittleHuba
left a comment
There was a problem hiding this comment.
Sorry, did not take a carefuly enough look after the last rebase.
This change does not actually remove usage of deprecated API anymore.
The code you changed from is already using a std::string now.
Could you please doublecheck that you really get the deprecation warning without your change @artemsheinacn ?
LittleHuba
removed
the
import-started-do-not-modify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: don't use deprecated API in config_parser